Skip to content

Conversation

@A-CGray
Copy link
Member

@A-CGray A-CGray commented Aug 26, 2025

Purpose

Updates repo to pass our new formatting and linting checks. There are a lot of whitespace changes here so once this PR is merged we can add the commit hash to a .git-blame-ignore-revs file.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner August 26, 2025 18:10
@A-CGray A-CGray requested review from ArshSaja and anilyil August 26, 2025 18:10
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.21%. Comparing base (8f6696b) to head (fa56f96).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
adflow/pyADflow.py 25.00% 12 Missing ⚠️
adflow/mphys/mphys_adflow.py 0.00% 2 Missing ⚠️
adflow/pyWingCG.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   41.19%   41.21%   +0.01%     
==========================================
  Files          13       13              
  Lines        4127     4125       -2     
==========================================
  Hits         1700     1700              
+ Misses       2427     2425       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sanjan98 sanjan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring codecov/patch failed test
Ruff mainly fixes whitespace issues in the Fortran files and some string conventions in the python files

@ArshSaja ArshSaja merged commit 03da3b9 into main Sep 8, 2025
14 of 15 checks passed
@A-CGray A-CGray deleted the ruffFixes branch September 8, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants