-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(placements): consolidate placement's ad overlay design #12104
base: main
Are you sure you want to change the base?
Conversation
…ements, use theme-aware colors
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
This makes all overlays look the same, and adds the overlay to the home page placements. Colors are now uniformly based on theme colors.
Problem
Design was different in different places and absent on home page.
Solution
A bit simpler css, a bit of JS changes
Screenshots
Before
After
How did you test this change?
locally