fix(css): fix upside-down rendering of CJK characters in translation #11922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdn/yari-content-ko Can you please take a look at this issue and the proposed solution? 🙏 |
1ilsang
suggested changes
Oct 9, 2024
There was a problem hiding this comment.
@bangseongbeom Hi, Thank you for your contribution!
I see the issue is resolved. Please fix the lint error.
client/src/document/ingredients/browser-compatibility-table/index.scss
Outdated
Show resolved
Hide resolved
|
@caugner Hi, Can you accept the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11921.
Problem
When I try to translate any MDN page to Korean using a browser translation tool, the characters on the browser compatibility table's header are reversed.
Solution
This is caused by the value of
text-orientationfor CJK characters beingmixed(default). This PR fixes this by changing it tosideways.Screenshots
Before
After
How did you test this change?