Editorial updates to ToggleEvent and ToggleEvent.source pages #41670
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
dipikabh
requested review from
chrisdavidmills
and removed request for
sideshowbarker
dipikabh
commented
Oct 25, 2025
| {{APIRef("Popover API")}} | ||
|
|
||
| The **`ToggleEvent`** interface represents an event notifying the user an Element's state has changed. | ||
| The **`ToggleEvent`** interface represents an event that fires when a popover element is toggled between being shown and hidden. |
There was a problem hiding this comment.
- might not be accurate to say that the user is notified
- also added the toggled states to the definition/intro
dipikabh
commented
Oct 25, 2025
|
|
||
| - {{domxref("ToggleEvent")}} | ||
| - : Represents an event notifying the user when a popover element's state toggles between showing and hidden. It is the event object for the {{domxref("HTMLElement.beforetoggle_event", "beforetoggle")}} and {{domxref("HTMLElement.toggle_event", "toggle")}} events, which fire on popovers when their state changes. | ||
| - : Represents an event that fires when a popover element is toggled between being shown and hidden. It is the event object for the {{domxref("HTMLElement.beforetoggle_event", "beforetoggle")}} and {{domxref("HTMLElement.toggle_event", "toggle")}} events, which fire on popovers when their state changes. |
There was a problem hiding this comment.
these changes are purely to align the description here with the intro on the "ToggleEvent" page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I came across the ToggleEvent and ToggleEvent.source pages while reviewing #41653 and noticed few opportunities where the text could be improved and made clearer.
I'll leave inline comments to explain some of the specific changes.