Skip to content

Set-Cookie: Domain directive default value clarification #41651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2025
Merged

Set-Cookie: Domain directive default value clarification #41651

merged 4 commits into from
Oct 28, 2025

Conversation

@hamishwillee
Copy link
Collaborator

Fixes #41646

@hamishwillee
Set-Cookie: Domain directive default value clarification
8346dbc 
Clarify the behavior of the 'Domain' attribute for cookies.
@hamishwillee hamishwillee requested a review from a team as a code owner October 24, 2025 00:12
@hamishwillee hamishwillee requested review from bsmth and removed request for a team October 24, 2025 00:12
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Oct 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie
Title: Set-Cookie header
Flaw count: 3

  • unknown:
    • No generic content config found
    • no blog root
    • no blog root

(comment last updated: 2025-10-27 01:30:32)

@hamishwillee hamishwillee mentioned this pull request Oct 24, 2025
Closed
hamishwillee
hamishwillee commented Oct 27, 2025
View reviewed changes
hamishwillee
hamishwillee commented Oct 27, 2025
View reviewed changes
github-actions[bot]
github-actions bot reviewed Oct 27, 2025
View reviewed changes
@hamishwillee @github-actions
Update files/en-us/web/http/reference/headers/set-cookie/index.md
446697b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bsmth
bsmth approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, thank you!

@hamishwillee hamishwillee merged commit d866d83 into main Oct 28, 2025
13 checks passed
@hamishwillee hamishwillee deleted the hamishwillee-cookie-domain branch October 28, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bsmth bsmth bsmth approved these changes

Assignees

No one assigned

Labels

Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set-Cookie without Domain attribute

2 participants

@hamishwillee @bsmth