docs: Add missing duplex property to RequestInit and update fetch() #40099
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrinivassab
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs Flaws (1)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2025-06-28 01:48:25) |
wbamberg
reviewed
Jun 27, 2025
There was a problem hiding this comment.
Thank you @Shrinivassab ! I realised we also need a page for the corresponding duplex property of Request. You could model this on, for example, https://developer.mozilla.org/en-US/docs/Web/API/Request/redirect.
Accepted PR commented... Co-authored-by: wbamberg <[email protected]>
Accepted PR commented... Co-authored-by: wbamberg <[email protected]>
Accepted PR commented... Co-authored-by: wbamberg <[email protected]>
…tent into add-duplex-docs
Hi @wbamberg I have incorporated your PR comments and in addition to that i added new page for duplex: Please go over it and share your review comments. I will update it based on your suggestions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
duplexproperty toRequestInit(alphabetically betweencredentialsandheaders).TypeErrorbehavior infetch()exceptions table when:bodyis aReadableStreambutduplexis omitted/not"half".duplexvalues are provided.Motivation
Additional details
Related issues and pull requests
Fixes #40086