-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Report type types coep #27047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Report type types coep #27047
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
"support": { | ||
"chrome": { | ||
"version_added": "69", | ||
"notes": "Includes support for non-standard type `coep`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this takes a non standard option corp
(, which is misprinted here as coep
)
I think I should make this yet one lower subfeature for this case, but ONLY include the invalid values.
My reasoning is that when corp
option is no longer supported, we'd need to track the change.
Thoughts?
"notes": "Includes support for non-standard type `coep`" | |
"notes": "Includes support for non-standard type `corp`" |
@caugner Thanks for your attention and taking this up in the BCD meeting. The spec is now updated in w3c/reporting#284 so But what this means is that this has become a "real" problem affecting all the current report types. If BCD is going to avoid dictionaries then the only option I see here is to add the information somehow to The actual place the objects appear is in a EDIT PS, I think this does mean we need to deprecate to_json in the |
@caugner And it just got even more messy in w3c/reporting#216 (comment) which seems to indicate that only report bodies which need to show up in The implication, which I am checking, is that COOP and COEP report types only appear in reporting server endpoints - i.e. they are JSON objects posted to a server and not things you can get via ReportingObserver. I have no idea what the "right thing" to do is now for COEP, COOP. Probably what we are proposing to do here, but you might argue that the information should go as a subfeature of the respective COOP / COEP headers - and I couldn't argue that. But the discussion above is still value for the other reporting types. |
This creates a PR to test the suggestion for structuring Reporting API report body types made in #27021 - what was suggested there did not quite survive attempted rollout.
For context,
Report
API with propertiestype
,body
,url
..body
can take an object that is derived fromReportBody
that differs based on thetype
.Report
,ReportBody
, and derived types such asInterventionReportBody
were originally IDL objects, which means that previously we could document body types in the body interfaces, such asInterventionReportBody
ReportBody
and possibly evenReport
to be dictionaries.Report
. Note that eventually this will probably have to go inReportingObserver
. Yuck.We have is a whole bunch of different string values for
Report.type
. We also have a whole bunch of possible report body properties, which vary or might potentially vary by type.@caugner Generally we document all properties of the web API objects (not just the ones that have changed). Since these properties "live" in an object mapped to
Report.body
that's where I've added them, grouped by type. So it looks like this:Note that I haven't yet added all the properties for the other types such as
type_csp-violation
- not worth it unless you agree this is the right approach.Let me know.
Related docs work done in mdn/content#39880