Node.js 11.7+ supports Worker + related updates
#25012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
This was referenced Nov 9, 2024
legendecas
reviewed
Nov 11, 2024
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
legendecas
reviewed
Nov 21, 2024
skyclouds2001
commented
Nov 23, 2024
queengooborg
requested changes
Dec 1, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
queengooborg
previously requested changes
Dec 17, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
|
@queengooborg Can you PTAL at this PR when you have a moment? |
caugner
requested changes
Jan 27, 2025
Comment on lines
+25
to
+33
| "nodejs": { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": [ | ||
| "Inherits from a Node `EventEmitter` instead of DOM `EventTarget`.", | ||
| "Also supports CommonJS modules, enabled for files ending with `.cjs` and for files ending with `.js` when the nearest parent `package.json` file contains a top-level field `\"type\"` with a value not of `\"commonjs\"`.", | ||
| "Available as a part of the `worker_threads` module." | ||
| ] | ||
| }, |
There was a problem hiding this comment.
✅ Verified that worker_threads.Worker exists in v12.0.0, which seems to be the gist of this change.
Comment on lines
+80
to
+84
| "nodejs": { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": "Takes entirely different options parameters." | ||
| }, |
There was a problem hiding this comment.
✅ Makes sense based on parent change.
Comment on lines
+303
to
+305
| "nodejs": { | ||
| "version_added": "11.7.0" | ||
| }, |
There was a problem hiding this comment.
✅ Verified locally with this worker.js, created via new worker_threads.Worker('./worker.js'):
const { Worker } = require('worker_threads');
const { writeFileSync } = require('fs');
writeFileSync('./worker.log', Worker, 'utf-8');
Comment on lines
+347
to
+349
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": "Supports the event, but only via Node `EventEmitter`." |
Comment on lines
+401
to
+405
| "nodejs": { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": "Supports the event, but only via Node `EventEmitter`." | ||
| }, |
There was a problem hiding this comment.
✅ Makes sense based on parent change.
Comment on lines
+454
to
+466
| "nodejs": [ | ||
| { | ||
| "version_added": "14.5.0", | ||
| "partial_implementation": true, | ||
| "notes": "Supports the event, but only via Node `EventEmitter`." | ||
| }, | ||
| { | ||
| "version_added": "12.19.0", | ||
| "version_removed": "13.0.0", | ||
| "partial_implementation": true, | ||
| "notes": "Supports the event, but only via Node `EventEmitter`." | ||
| } | ||
| ], |
There was a problem hiding this comment.
✅ Verified via the referenced PR.
api/Worker.json
Outdated
Comment on lines
541
to
548
| "nodejs": { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": [ | ||
| "The options parameter is not supported; the second parameter may only be an array of objects to transfer.", | ||
| "Only supports transferring `ArrayBuffer` and `MessagePort` objects." | ||
| ] | ||
| }, |
There was a problem hiding this comment.
✅ Makes sense based on parent change.
New note:
The options parameter is not supported; the second parameter may only be an array of objects to transfer.
| }, | ||
| { | ||
| "version_added": "11.7.0", | ||
| "partial_implementation": true, | ||
| "notes": "Also takes an optional callback to be executed when the worker has terminated." | ||
| "notes": "Takes an optional callback parameter to be executed when the worker has terminated." |
Co-authored-by: Claas Augner <[email protected]>
caugner
approved these changes
Jan 28, 2025
caugner
changed the title
WorkerWorker + related updates
caugner
dismissed
queengooborg’s stale review
Requested changes were applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update the data for
Worker, as there is already a ecmascript_modules field shows the ESM supportthe data for
errorevent is confirmed with the intial pr nodejs/node#20876the data for
messageerrorevent andterminate()method come from the documentation, also confirmed by release and impl prhttps://nodejs.org/zh-cn/blog/release/v12.19.0
https://nodejs.org/zh-cn/blog/release/v14.5.0
nodejs/node#33772
https://nodejs.org/zh-cn/blog/release/v12.5.0
nodejs/node#28021
Test results and supporting details
confirmed by landing PRs and release notes
also test in local node runtime:
Related issues