Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixin consistency #16439

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix mixin consistency #16439

merged 2 commits into from
Jun 1, 2022

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented May 26, 2022

This PR fixes the version consistency between the main API files and the mixin files. Required to land #16437.

@queengooborg queengooborg requested a review from foolip May 26, 2022 19:03
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 26, 2022
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed (almost) all of the Safari things to be in WebKit from the start. Can you update the interfaces instead to fix the consistency?

Co-authored-by: Philip Jägenstedt <[email protected]>
@foolip
Copy link
Contributor

foolip commented Jun 1, 2022

Hmm, why does the CI pass now? Did you change the parent interfaces in some other PR?

@foolip
Copy link
Contributor

foolip commented Jun 1, 2022

Oh right, it's because #16437 isn't landed yet :)

@queengooborg queengooborg merged commit 359f286 into mdn:main Jun 1, 2022
@queengooborg queengooborg deleted the api/consistency branch June 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants