Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique index for code column #667

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented Mar 3, 2025

This adds a unique database key to quickly lookup certificates.

Thank you to @Raza403 for contributing his work to this fix.

Fixes #666.

@fulldecent
Copy link
Contributor Author

@mdjnelson for your review, please

@fulldecent
Copy link
Contributor Author

Hi @mdjnelson could you please approve to run the workflow?

@mdjnelson
Copy link
Owner

Done. The only issue with me merging is the upgrade path. The number needs to be different for each supported version. I will do this myself, no worries but need to set some time aside to go over a few PRs.

@fulldecent
Copy link
Contributor Author

Thank you, much appreciated.

If there's anyway that I can make your job easier next time, please leave some notes in the README or CONTRIBUTING file.

I have another PR here and planning to work on an additional one after that.

@mdjnelson
Copy link
Owner

Putting this in now. The version bumps are because we dont want to bump all the branches to the same version, as there may be upgrades, say for example, just for 4.2. If someone upgrades to the same version on 4.1 then updates their code to use 4.2 they are going to miss those upgrade steps necessary in 4.2

@mdjnelson mdjnelson closed this Mar 30, 2025
@mdjnelson
Copy link
Owner

All done, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup by code is slow
2 participants