Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting data from Safari 13.1 crashes Safari #94

Open
foolip opened this issue May 25, 2020 · 7 comments
Open

Collecting data from Safari 13.1 crashes Safari #94

foolip opened this issue May 25, 2020 · 7 comments

Comments

@foolip
Copy link
Collaborator

foolip commented May 25, 2020

Following https://github.com/mdittmer/web-apis#manual-data-collection-setup I get Safari 13.1 to crash when visiting https://wpt.foolip.org/ and clicking "Collect data":
image

(wpt.foolip.org is a domain I use for running ./wpt serve for web-platform-tests sometimes, but it uses the same port 8000, so I also use it for running this tool.)

It doesn't crash on STP 106, however.

@othermaciej
Copy link

Is this a literal crash? If so, could you please share a crash report (perhaps at bugs.webkit.org)?

@foolip
Copy link
Collaborator Author

foolip commented May 25, 2020

I think it's a renderer crash given the message. For Safari stable, how can I get a crash report for sharing?

@stephenmcgruer
Copy link

stephenmcgruer commented May 27, 2020

@foolip this may not happen if its a renderer crash, but does anything show up in ~/Library/Logs/CrashReporter? (https://webkit.org/getting-a-crash-log/)

Edit; I think Safari calls their renderer process a 'WebProcess', incidentally.

@foolip
Copy link
Collaborator Author

foolip commented May 28, 2020

I just got a macOS update so I tried again, but it still crashes every time. ~/Library/Logs/CrashReporter doesn't exist, but I did find a ~/Library/Logs/DiagnosticReports/com.apple.WebKit.WebContent_2020-05-28-093039_foolip-macbookpro.crash, one similar file per crash.

Now I'm curious, so I'll try making this a standalone test case and minify a bit.

@foolip
Copy link
Collaborator Author

foolip commented May 28, 2020

I have filed https://bugs.webkit.org/show_bug.cgi?id=212458. I suspect it's been fixed, so I didn't minimize all the way down, probably the logs can reveal what this is a dupe of.

@Constellation
Copy link

Note that it is fixed in r262693, thanks so much for reporting! https://trac.webkit.org/changeset/262693/webkit

@stephenmcgruer
Copy link

Thanks @Constellation ! Is there a way for us to tell when that makes it to a Safari release (I know Apple does not comment on upcoming releases, just looking for a way we can tell when it has hit a release)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants