Add support for native pass backend
#37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Feb 28, 2023
| @@ -30,10 +30,10 @@ async def register_service(pass_store): | |||
| return service | |||
|
|
|||
|
|
|||
| def _main(path, verbose): | |||
| def _main(path, pass_, verbose): | |||
There was a problem hiding this comment.
Suggested change
| def _main(path, pass_, verbose): | |
| def _main(path, pass_binary, verbose): |
|
@nodatapoints are you interested in finishing this? Should somebody else pick it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a basic backend for the native
passbinary as suggested by #35.It can be enabled by passing
-e <pass-binary>topass_secret_service. Furthermoreit is used as a fallback when
pypassis not found.All tests are passing.
Looking foward, I suggest dropping
pypassand only usingpass, since there does not seem to be active development and I don't see any benefit in usingpypassinstead of the main application.