Fixed the sign of the angle in image.rotate() method #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image.rotate() method used in Operations.py was using a positive angle for performing clockwise rotation and a negative angle for anticlockwise rotation, which was opposite with the behavior of the image.rotate() function that is when this function is given positive angle of rotation then it rotates in anticlockwise direction and for negative angle of rotation it rotates in clockwise direction. This commit corrects the sign of the angle of rotation provided inside the image.rotate() method to ensure the rotation is performed correctly according to the desired clockwise and anticlockwise directions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#252
The image.rotate() method used in Operations.py was given a positive angle for performing clockwise rotation and a negative angle for anticlockwise rotation, which was opposite to the behavior of the image.rotate() function which is when this function is given a positive angle of rotation then it rotates in the anticlockwise direction and for a negative angle of rotation it rotates in the clockwise direction. This commit corrects the sign of the angle of rotation provided inside the image.rotate() method to ensure the rotation is performed correctly according to the desired clockwise and anticlockwise directions.
Link for testing code and the result images before and after my change.
https://drive.google.com/drive/folders/1MWlUfkjTjIaS0WnxdH5Gz2PlatFKhXyC?usp=sharing