Skip to content

scripts: imgtool: Compression of no header-padded images #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

nordic-mik7
Copy link
Contributor

@nordic-mik7 nordic-mik7 commented Jun 9, 2025

This fixes issues when trying to compress images with no
header padding requested.

@nordic-mik7 nordic-mik7 requested a review from d3zd3z as a code owner June 9, 2025 15:18
@nordic-mik7 nordic-mik7 force-pushed the dev/compression_no_padding branch from af683f4 to 05b5091 Compare June 9, 2025 15:19
@nordicjm nordicjm requested a review from michalek-no June 10, 2025 07:00
@de-nordic de-nordic requested a review from nordicjm June 11, 2025 09:29
Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed, discussed F2F

This fixes issues when trying to compress images with no
header padding requested.

Signed-off-by: Michal Kozikowski <[email protected]>
@nordic-mik7 nordic-mik7 force-pushed the dev/compression_no_padding branch from 05b5091 to cd424a8 Compare June 11, 2025 14:41
@nordic-mik7 nordic-mik7 requested a review from nvlsianpu June 11, 2025 14:42
@nordic-mik7
Copy link
Contributor Author

@nvlsianpu discussed issues were adressed

@nvlsianpu nvlsianpu merged commit 9e0bebc into mcu-tools:main Jun 12, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants