Skip to content

Update extension_list.fds #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

Hugs288
Copy link
Contributor

@Hugs288 Hugs288 commented Apr 26, 2025

No description provided.

@mcmonkey4eva
Copy link
Member

I'm confused

https://github.com/Hugs288/NegPipforSwarmUI/blob/main/NegPipforSwarmUI.cs#L51

You're adding the node... before absolutely anything else at all ever? That doesn't seem like a good idea. Especially the odd choice of ultra low negative value

@mcmonkey4eva
Copy link
Member

Also, is an entire param group needed for a single parameter? 0.o

@Hugs288
Copy link
Contributor Author

Hugs288 commented Apr 26, 2025

oop, good catch i did that for testing purposes, ill make it -10, i think thats fine?

as for the param group, idk a better way to do it, sorry.

@mcmonkey4eva
Copy link
Member

-10 is when loras load, most guidance-muckery-type-stuff is -7

and: you can put it into any existing group that fits appropriately

@Hugs288
Copy link
Contributor Author

Hugs288 commented Apr 27, 2025

done, put it under the sampling group and its now false by default.

@mcmonkey4eva
Copy link
Member

You'll also want IgnoreIf: "false" so it doesn't add to metadata when disabled

@mcmonkey4eva
Copy link
Member

and to remove the group that does nothing

@mcmonkey4eva
Copy link
Member

aaand update the JS asset to put the installer in the Sampling group that's in use now instead of the old group

@mcmonkey4eva mcmonkey4eva merged commit 6754e15 into mcmonkeyprojects:master Apr 28, 2025
@Hugs288
Copy link
Contributor Author

Hugs288 commented Apr 28, 2025

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants