Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Temporarily fix the gemini structured output error #986

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

lingyielia
Copy link
Contributor

@lingyielia lingyielia commented Feb 4, 2025

Description

Provide a temp fix to enable gemini models before the proper dependencies (pydantic v2 and langchain 0.3) are in place.

related to: #871

Screenshot

Screenshot 2025-02-05 at 17 50 17

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-02-07 22:40:02 UTC
Commit: fb599e7

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@lingyielia lingyielia marked this pull request as ready for review February 4, 2025 01:41
@huong-li-nguyen huong-li-nguyen linked an issue Feb 4, 2025 that may be closed by this pull request
1 task
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it out in terms of running the model, but I just looked at the code. Minor comments, but looks good to me 👍 Thanks for fixing! 🚀

vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen changed the title Temporarily fix the gemini structured output error [Fix] Temporarily fix the gemini structured output error Feb 4, 2025
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, thanks for digging so deep, that must not have been fun... 💯 ⭐

I cannot get this to run though, so before merging, let's please check together why I cannot get this to work with Google - might be an issue on my side, but I just want to be sure.

vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
vizro-ai/src/vizro_ai/dashboard/_pydantic_output.py Outdated Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen self-requested a review February 6, 2025 08:07
@lingyielia lingyielia merged commit 5e30406 into main Feb 7, 2025
45 checks passed
@lingyielia lingyielia deleted the patch/gemini_api_error branch February 7, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Google Gemini support Vizro-AI?
3 participants