-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Improve appearance of README on PyPI #969
[Tidy] Improve appearance of README on PyPI #969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @manuelkonrad - thanks for taking on another issue! 🚀
This looks good to me. I have a few minor comments, but it's ready to merge from my side 👍 I'll leave the final review to @stichbury or @Joseph-Perkins .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be just a browser issue. Is this what you see when you click on this link? For me, it looks fine 👍 |
That does look fine. I'm looking at the changed file in the PR though, and that doesn't: https://github.com/mckinsey/vizro/blob/ac400c876856f04bef519d29faf8b1eef857bb6c/README.md Could be just because it's on a fork I guess. |
Co-authored-by: Li Nguyen <[email protected]>
As suggested by @huong-li-nguyen, I also changed the image reference in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @manuelkonrad!
Ahhh this issue has bugged me for ages! I'm so pleased to see it resolved. Thank you very much for your contribution @manuelkonrad. |
@antonymilne Let's see after the next release whether the PyPI page actually looks better (or you upload to Test PyPI in the meantime). BTW, really amazing how fast you iterate on PRs! |
We just released - it looks great! 🚀 https://pypi.org/project/vizro/ |
Description
picture
element. Not sure if it helps.If not, you can provide an alternative PNG in theAdded fallback PNGs.img
element (will serve as fallback).vizro-ai
andvizro-core
so they render better in PyPI #380Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":