Skip to content

Commit

Permalink
[Fix] Lower lower-bound of pydantic (#993)
Browse files Browse the repository at this point in the history
  • Loading branch information
maxschulz-COL authored Feb 5, 2025
1 parent 0f2eb9a commit a5ee752
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 6 deletions.
5 changes: 1 addition & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ repos:
- id: mypy
files: ^vizro-core/src/
additional_dependencies:
# Deliberately pinned to <2 until we bump our pydantic requirement to strictly >=2.
# pydantic>=1.10.15 includes this fix which flags some genuine type problems. These will take a while to fix
# or ignore so for now we just pin to 1.10.14 which doesn't flag the problems.
# https://github.com/pydantic/pydantic/pull/8765
# Deliberately pinned to 2.9.0 (and not lower) as there are issues building the wheel for pydantic-core
- pydantic==2.9.0

- repo: https://github.com/awebdeveloper/pre-commit-stylelint
Expand Down
48 changes: 48 additions & 0 deletions vizro-core/changelog.d/20250205_101357_maximilian_schulz.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨
- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Removed
- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Added
- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Changed
- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Deprecated
- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->

### Fixed

- Adjust the lower bound of pydantic to `2.7.0` so that Vizro can run on pyodide. ([#993](https://github.com/mckinsey/vizro/pull/993))


<!--
### Security
- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
2 changes: 1 addition & 1 deletion vizro-core/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ VIZRO_LOG_LEVEL = "DEBUG"

[envs.lower-bounds]
extra-dependencies = [
"pydantic==2.9.0",
"pydantic==2.7.0",
"dash==2.18.0",
"plotly==5.24.0",
"pandas==2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion vizro-core/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies = [
"dash-ag-grid>=31.0.0",
"pandas>=2",
"plotly>=5.24.0",
"pydantic>=2.9.0", # must be synced with pre-commit mypy hook manually
"pydantic>=2.7.0", # must be <= the version in pre-commit mypy hook, sync manually
"dash_mantine_components~=0.15.1",
"flask_caching>=2",
"wrapt>=1",
Expand Down

0 comments on commit a5ee752

Please sign in to comment.