-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to martinohmann difflib fork and colorize diff output #423
base: master
Are you sure you want to change the base?
Conversation
@@ -64,6 +64,7 @@ func (f FiltersDiff) String() string { | |||
FromFile: "Current", | |||
ToFile: "TO BE APPLIED", | |||
Context: f.ContextLines, | |||
Color: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind making this optional through a flag?
Some people rely on this in scripts, which would suddenly have garbled logs in them.
To make this nicer, there could be an automatic TTY detection, but this can definitely happen later.
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 54.52% 54.51% -0.01%
==========================================
Files 53 53
Lines 4457 4459 +2
==========================================
+ Hits 2430 2431 +1
- Misses 1886 1887 +1
Partials 141 141 ☔ View full report in Codecov by Sentry. |
This pull request is stale because it has been open for 30 days without activity. |
keepalive |
This would at least be a partial solution to #371.
I did not add the colorization to the cfgtest output, but I wonder if I should.