improve createProgressBar, update homepage, fix css bug #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed bug introduced in commit 9d53dfd. Added reference to "id" in
"createProgressBar" function call in a few places. Since the argument
order was important, that broke a few things (classes, desc, etc).
Changed the function to accept an object and look for object
attributes so as to avoid that bug in the future.
- changed data to be applied directly to the progress bar, rather than
to be added to a "dataObj" object which was then applied to the
progress bar. This is useful because we can now more cleanly make
this plugin work with other plugins, such as the Bootstrap popovers,
by applying data attributes directly to the element. (See sample
code in index.html.)
- changed style.css so that the "today" element is applied last. Current
behavior will only apply color to the current hour/day/week/month cell
if it's a non-holiday weekday. Changed the ordering in the css file
so it's always applied last.
- updated index.html to:
* use CDN for jquery
* to always have example dates close to the current date (otherwise
the "go to current date" functionality appears not to work)
* not make http/https assumptions
* add data element example
* improve bootstrap popover example
- re-minimized function using google closure compiler
(http://closure-compiler.appspot.com/home)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idin thecreateProgressBarfunction call in a few places (e.g., here). Since the argument order was important, that broke a few things (classes, desc, etc). Changed the function to accept an object and look for object attributes so as to avoid that bug in the future.createProgressBarfunction so that data is applied directly to the progress bar, rather than to be added to adataObjobject which was then applied to the progress bar. This is useful because we can now more cleanly make this plugin work with other plugins, such as the Bootstrap popovers, by applying data attributes directly to the element. (See sample code in index.html.)todayclass is defined last. Current behavior will only apply color to the current hour/day/week/month cell (e.g., today) if it's a non-holiday weekday. Changed the ordering in the css file so the today cell is always highlighted.