Replace C++11 raw string literal by C array#90
Open
aleksander wants to merge 1 commit intombevand:masterfrom
Open
Replace C++11 raw string literal by C array#90aleksander wants to merge 1 commit intombevand:masterfrom
aleksander wants to merge 1 commit intombevand:masterfrom
Conversation
Kubuxu
reviewed
Dec 14, 2016
Makefile
Outdated
| echo ')_mrb_";' >>$@ | ||
| _kernel.h: input.cl param.h | ||
| cpp $< ocl.code | ||
| echo -ne "\x00" >> ocl.code |
There was a problem hiding this comment.
echo -n is not portable, please use printf instead.
aleksander
force-pushed
the
clcode-as-c-array
branch
2 times, most recently
from
fc89d50 to
7b900f7
Compare
Owner
|
This seems good. I'll merge this at some point. |
aleksander
force-pushed
the
clcode-as-c-array
branch
from
7b900f7 to
ba3f136
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces C++11 raw string literal
R"_mrb_( ... )_mrb_"by C array.Main reason for this is possibility to compile with clang instead of gcc.