Refactor and test - #9
Open
alireza995 wants to merge 28 commits into
Open
Conversation
change version to 1.0.1
replace DotnetCore pakage with Kavenegar.Core
update nuget page address
… special charecters like &<>+# from message
Prevent changing special charecters like &<>+# inside message
Refactor all codes with: Creating sln file move each class in a new file remove unusable code create some temp changes closes nothing
relocate files and remove unnecessary files closes nothing
recreate kavenegarapi closes nothing
Remove unnecessary classes and file. Recreate csproj. Fix spelling naming problems. Add DI infrastructure. and mane more... closes nothing
Remove unused enum closes nothing
Refactor whole system
relocate codes and create test project
refactor with separating classes into related activities add new methods to send messages easier dependency manager completed closes nothing
Separate KavenegarApi class into and make it testable and create test class for methods which send single message closes nothing
test all methods of KavenegarMessageSender class closes nothing
Test kavenegarprofile and shared project closes nothing
create test project closes nothing
test all basic methods of all actions closes nothing
Add easy constructor for projects with no DI closes nothing
Test/integration
refactor controllers and handle null ResultStatus.cs closes nothing
refactor(IntegrationTest) : refactor controllers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have refactored entire system and made unit test for every single line of code
Also created a web api project to easily test functionality of every method