Skip to content

Update large CFN templates from S3 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rnhurt
Copy link
Contributor

@rnhurt rnhurt commented Dec 26, 2024

This PR adds the ability to upload detect large CFN templates and upload them the S3 before applying the update.

Steps:

  1. stack-update checks the template size
  2. If it's too large it uploads the file to a user defined bucket (CFN_BUCKET ENVAR)
  3. Update the update-stack function to include a "template-path" option

NOTES:

  • I wasn't sure how to document the ENVAR needed for this.
  • It seems like "bash-my-aws" doesn't utilize ENVARs much but I thought this would be a nice way to add the functionality without changing anything user-facing.

@rnhurt rnhurt requested a review from mbailey as a code owner December 26, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant