Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google scopes for v4 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jmarrec
Copy link

@jmarrec jmarrec commented Sep 20, 2023

  • Replace the scopes with the new ones
  • Reuse SCOPES from utils instead of duplicating

Note: I realized this repo is probably abandoned, just upstreaming it here in case it serves someone else.

@@ -16,15 +16,9 @@
import pandas as pd
import numpy as np

from .utils import get_credentials
from .utils import get_credentials, SCOPES
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse

Comment on lines 27 to +30
SCOPES = ('https://www.googleapis.com/auth/drive.metadata.readonly '
'https://www.googleapis.com/auth/drive '
'https://spreadsheets.google.com/feeds '
'https://docs.google.com/feeds')
'https://www.googleapis.com/auth/spreadsheets '
'https://www.googleapis.com/auth/docs')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

@elgalu
Copy link

elgalu commented Sep 21, 2023

yep, seems abandoned, question: why don't you use gspread (2023) or pygsheets (2022) ? or different use cases?

@jmarrec
Copy link
Author

jmarrec commented Sep 21, 2023

I have 3 pandas dataframes that I need to upload to google sheets, for updating really (one where I also start from google sheets). I do that twice a year only, until now it just worked. Don't feel the pressure to do differently if it takes 10 minutes to patch to keep up.
Also, this is built on gspread already.

@jmarrec
Copy link
Author

jmarrec commented Sep 21, 2023

import gspread

@jmarrec
Copy link
Author

jmarrec commented Sep 21, 2023

I didn't know about pygsheets, I'll check it out

@jmarrec
Copy link
Author

jmarrec commented Sep 21, 2023

@elgalu I'm genuinely interested in how you landed on this PR?

@elgalu
Copy link

elgalu commented Sep 22, 2023

we provide an internal container image runtime with a bunch of packages and the ones that are not maintained start giving problems, like this one:) so thanks for the PR as we're now pinning to your fix<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants