Update to jsonwebtoken v10
#176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `aws-lc-rs` and `rust-crypto` features, exactly one of which is required to be enabled by `jsonwebtoken` v10. `rust-crypto` is now part of `default` features. Use new `jsonwebtoken::dangerous::insecure_decode` to support jsonwebtoken v10, which introduced breaking changes to the previous workaround to insecurely decode a JWT. BREAKING CHANGE: `rust-crypto` and `aws-lc-rs` are mutually exclusive so `--all-features` will fail. This is an inherent limitation of `jsonwebtoken` v10 at this time. BREAKING CHANGE: dependency on `ring` is eliminated and replaced by either `aws-lc-rs` OR `rust-crypto`. Signed-off-by: Dwayne Sykes <[email protected]>
Signed-off-by: Dwayne Sykes <[email protected]>
dsykes16
force-pushed
the
jsonwebtoken-10
branch
from
09ea6c7 to
31a4027
Compare
Add 'Run Integration Tests with aws-lc-rs' step to 'Build and Test' CI job to ensure functionality with `aws-lc-rs` (alternative to `rust-crypto`). Signed-off-by: Dwayne Sykes <[email protected]>
dsykes16
force-pushed
the
jsonwebtoken-10
branch
from
e4ef7b3 to
e7d2475
Compare
|
This will supersede #173. Once Keats/jsonwebtoken#441 is merged and a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
aws-lc-rsandrust-cryptofeatures, exactly one of which isrequired to be enabled by
jsonwebtokenv10.rust-cryptois nowpart of
defaultfeatures.Use new
jsonwebtoken::dangerous::insecure_decodeto supportjsonwebtoken v10, which introduced breaking changes to the previous
workaround to insecurely decode a JWT.
BREAKING CHANGE:
rust-cryptoandaws-lc-rsare mutually exclusive so--all-featureswill fail. This is an inherent limitation ofjsonwebtokenv10 at this time.BREAKING CHANGE: dependency on
ringis eliminated and replaced byeither
aws-lc-rsORrust-crypto.