Fix Pure Black theme regression with Material 3#1
Fix Pure Black theme regression with Material 3#1maximillions-dev wants to merge 2 commits intomainfrom
Conversation
Material 3 uses surfaceContainer roles for many backgrounds. This commit ensures that when Pure Black theme is enabled, these container colors are also set to Color.Black, restoring the full AMOLED black experience. Fixes MetrolistGroup#2725
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Material 3 uses surfaceContainer roles for many backgrounds. This commit ensures that when Pure Black theme is enabled, these container colors are also set to Color.Black, restoring the full AMOLED black experience. Additionally, this commit updates the CI workflows to conditionally sign APKs only when the KEYSTORE secret is available, preventing build failures in environments without signing keys. Fixes MetrolistGroup#2725
maximillions-dev
deleted the
fix-pure-black-theme-issue-2725-1429133520031871373
branch
1 participant
Updated
pureBlackextension function inapp/src/main/kotlin/com/metrolist/music/ui/theme/Theme.ktto explicitly setsurfaceContainer,surfaceContainerLow,surfaceContainerLowest,surfaceContainerHigh, andsurfaceContainerHighesttoColor.Blackin the ColorScheme. This addresses the regression where components using these new Material 3 color roles were not appearing as pure black.PR created automatically by Jules for task 1429133520031871373 started by @maximillions-dev