Into worker and into scheduler for Job #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/job.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<I, S> Into<Worker<Job<I, S>>> for Job<I, S> |
Owner
There was a problem hiding this comment.
We probably want to implement From for Worker and Scheduler each, since implementing Into directly is discouraged.
Contributor
Author
There was a problem hiding this comment.
Hmmm... nice! Sorry my Rust noobism here. I will change it accordingly.
victoronascimento
force-pushed
the
feat/into_worker_and_scheduler
branch
from
4c8208a to
5e890a8
Compare
Contributor
Author
|
Done @maxcountryman ! Had to make the Thanks once again for your guidance on this. |
victoronascimento
force-pushed
the
feat/into_worker_and_scheduler
branch
from
5e890a8 to
73a5ca4
Compare
Contributor
Author
|
Rebased upon main |
Since `Job` has all its attributes private to the module, the only way to create a worker or scheduler is to either keep a reference to the queue used in the job creation. Implementing `From<Job<I, S>>` for `Worker` and for `Scheduler` makes it so all we need is the job reference.
victoronascimento
force-pushed
the
feat/into_worker_and_scheduler
branch
from
73a5ca4 to
aac91e2
Compare
Contributor
Author
|
Sorry for the noise. Ran every command from the pipeline locally now. |
Owner
|
@victoronascimento I think #100 will address this, but let me know if not. |
Contributor
Author
|
This is awesome! It certainly address this in a much better way. Thanks once again for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Job has all its attributes private to the module, the only way to create a worker or scheduler is to either keep a reference to the queue used in the job creation.
Implementing Into<Worker<Job<I, S>>> and Into<Scheduler<Job<I, S>>> makes it so all we need is the job reference.
Fixes #88