Fix parsing of last {...} section in *.items files to allow inner curly braces inside quoted values#74
Open
mannemiethe wants to merge 3 commits intomaxbec:masterfrom
Open
Fix parsing of last {...} section in *.items files to allow inner curly braces inside quoted values#74mannemiethe wants to merge 3 commits intomaxbec:masterfrom
mannemiethe wants to merge 3 commits intomaxbec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Max, would be nice if you merge this:
Problem
*.items files were getting corrupted when the final {...} block contained nested curly braces in quotes (e.g., JSON-like metadata). The previous regex patterns assumed no additional braces inside this block, causing parsing errors and invalid file output.
Cause
The old regex for the last {...} section was too restrictive:
These patterns failed when braces appeared inside quoted strings.
Solution
Replaced the regex with more permissive patterns that:
Capture the entire trailing {...} block.
Allow curly braces only inside quoted values (unquoted braces remain invalid).
Preserve optional [tags] syntax.
Example (now supported):

String ColorLightOffice_name "Color Light Office" <colorlight> (ColorLightOffice) ["Control"] { initializeDefaultState="{'de_name': 'Farb Licht', 'en_name': 'Color Light', 'location2': {'name': 'Color Light', 'location': 'Office'}}" }Impact:
✅ Fixes corruption when inner braces appear inside quoted values.
⚠️ Inner braces outside quotes remain invalid (by design).
✅ Maintains compatibility with existing item definitions.