Backport msc4190 from bridgev2 #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discord is on v0.16.x, not v0.16.0.x Easiest way to test local changes is adding |
onestacked
force-pushed
the
msc4190-bridgev1-backport
branch
from
4475e9a to
991c640
Compare
Changed to correct target branch
I wanted to avoid having to use the whole discord bridge, but It seems to work in my test setup with mautirx-discord, synapse & MAS. |
|
I've added a draft PR to mautrix-discord for the config change. |
|
@tulir can this (and the mautrix-discord change) be included in the May releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've attempted to backport the msc4190 support form bridgev2.
The main reason for this is to allow mautrix-discord to use msc4190 before the bridgev2 rewrite.
I think this should work, but I'm unsure how to test this.From what I undestandThe (encryption) config upgrade needs to be done in the bridge itself instead of here.Draft PR to mautrix-discord