Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#68] Allow section names to be unique within lessons only #69

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mauriciofierrom
Copy link
Owner

Closes #68

  • Add migration to fix the unique index
  • Add scope to the uniqueness validation
  • Add user factory
  • Add user association to lesson factory
  • Lesson factory corrections
  • Add section factory
  • Add section model spec

NOTE: We modify the start_time and end_time validations to provide a default value for lesson.duration_in_seconds because there's an issue with shoulda matchers and validations that refer to associated models thoughtbot/shoulda-matchers#1435

- Add migration to fix the unique index
- Add scope to the uniqueness validation
- Add user factory
- Add user association to lesson factory
- Lesson factory corrections
- Add section factory
- Add section model spec

NOTE: We modify the start_time and end_time validations to provide a
default value for lesson.duration_in_seconds because there's an issue
with shoulda matchers and validations that refer to associated models
according to this issue thoughtbot/shoulda-matchers#1435
@mauriciofierrom mauriciofierrom merged commit db1c639 into main Jul 23, 2024
1 check passed
@mauriciofierrom mauriciofierrom deleted the 68-allow-sections-unique-within-lessons branch July 23, 2024 06:49
@mauriciofierrom mauriciofierrom changed the title [#68] Allow sections to be unique within lessons only [#68] Allow section names to be unique within lessons only Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Section names to be unique within lessons only
1 participant