fix filter condition to only exclude false (#109)

mattwparas · Dec 4, 2023 · 88612db · 88612db
1 parent 881262e
commit 88612db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cogs/r5rs.scm b/cogs/r5rs.scm
@@ -41,6 +41,8 @@
 (check-equal? "Parsing octal" #o0777 511)
 (check-equal? "Parsing binary" #b0110 6)
 
+(check-equal? "filter treats lists as true" (filter (lambda (n) (list 1 2)) (list 1 2)) '(1 2))
+
 (check-equal?
  "Symbols are interned correctly - lists should use the existing symbols that have been interned"
  (eq? 'definitely-hasnt-been-seen-before

diff --git a/crates/steel-core/src/steel_vm/transducers.rs b/crates/steel-core/src/steel_vm/transducers.rs
@@ -267,9 +267,8 @@ impl<'global, 'a> VmCore<'a> {
 
                             match res {
                                 Ok(k) => match k {
-                                    SteelVal::BoolV(true) => Some(Ok(arg)),
                                     SteelVal::BoolV(false) => None,
-                                    _ => None,
+                                    _ => Some(Ok(arg)),
                                 },
                                 Err(e) => Some(Err(e)),
                             }