Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonoff TH10/TH16 initial support #151

Open
wants to merge 1 commit into
base: V3-Firmware
Choose a base branch
from

Conversation

fsalomon
Copy link

@fsalomon fsalomon commented Jul 19, 2020

This adds some initial support for https://www.itead.cc/wiki/Sonoff_TH_10/16 and adds "device_class" cli option
Usage: pysonofflanr3 --host xxx --device_id xxx --api_key xxx --device_class SonoffTemperatureHumidity on

Currently, only on/off are supported. If device is in "temperature" mode, it will switch to "normal" mode. I plan to add temperature read out and manipulation of temperature low/high target later once this PR is merged.

Please check if that matches your code style/best practices. Disclaimer: I'm not really a Python guy.

@mattsaxon
Copy link
Owner

mattsaxon commented Jul 20, 2020

As you can see, the build is failing above, not sure why, it seems to have started failing some weeks back. However I note that your PR hasn't updated the tests or the readme, so even if the build were passing, it wouldn't be ready to integrate.

Does the test suite run on your machine as it looks like some external dependency has broken the Travis build

@Lasszo
Copy link

Lasszo commented Feb 20, 2022

Hello Guys,

Can someone help me out how to add the --device_class option to the script ?

Error: no such option: --device_class

I have updated the 3 files from /usr/local/lib/python3.8/dist-packages/pysonofflanr3/

Thank you,

@mattsaxon
Copy link
Owner

Sorry I don't maintain this integration anymore. I've moved to the integration Alexxit created for home assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants