Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in symbol name for server variable validations #385

Merged

Conversation

theoriginalbit
Copy link
Contributor

I've made sure to introduce the fixed spellings as new symbols and add deprecation warnings with Fit-Its on the existing symbols so this is not a breaking change and won't require a major version bump; though the upcoming 4.x could be a good time to completely remove the misspelt symbols.

Copy link
Owner

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking the care to deprecate.

@mattpolzin mattpolzin merged commit cf31c5d into mattpolzin:main Oct 8, 2024
25 checks passed
@theoriginalbit
Copy link
Contributor Author

Looks good. Thanks for taking the care to deprecate.

No worries 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants