Java's eclipse-jdt-ls does not offer suggestions after a dot #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing a dot after typing an instance variable in a Java method body to see its members and other definitions as suggestions is not working currently in eclipse-jdt-ls for Java. While this is working for imports, methods do not get resolved. This commit replaces a suspicious dot that may be related to this, which causes the issue to get fixed.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that there is an error in the way
refresh_patternis set for eclipse-jdt-ls, that prevents complete suggestions to be shown after a dot has been typed (such as using the dot to access the methods of an instance variable).The refresh pattern was originally set in #490. Other issues in vim-lsp and vim-lsp-settings seem to be pointing to this:
As seen in the following case, while suggestions work after typing a dot in the import statement, typing a dot inside a method body does not present suggestions.
Screen.Recording.2024-03-06.at.14.38.53.mov
Patching the refresh_pattern for eclipse-jdt-ls and removing the dot as proposed in the patch causes dots to always trigger the completion menu, both on imports and on method bodies:
Screen.Recording.2024-03-06.at.14.40.41.mov
I know little about Vim patterns and their differences in regard to normal PCRE patterns and while the fix seems to work and is aligned with the experience of other people in issues linked above, I'm scared about unexpected consequences of changing this.