Verify metadata check header layout #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look again... |
matthiasbeyer
force-pushed
the
verify-metadata-check-header-layout
branch
2 times, most recently
from
6776cc1 to
0934f16
Compare
|
I don't like the impl here at all... |
Signed-off-by: Matthias Beyer <[email protected]>
This patch adds a verification implementation that the header of a Fragment actually obeys the configuration Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
The "Verification" error variant should not group errors, but the "Multiple" variant should. Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
The previous implementation did consider non-changelog-fragment-files as well, which is not what we want here. Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
matthiasbeyer
force-pushed
the
verify-metadata-check-header-layout
branch
from
0934f16 to
fc6fb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
@TheNeikos feel free to have a look.