Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mm-29] - Adds a confirmation button when creating a meeting on channels #49

Closed
wants to merge 3 commits into from

Conversation

maisnamraju
Copy link

Summary

Fixes #29 It adds a warning whenever there are members in a channel and asks user if they want to create the meeting. This doesn't have support for the mobile UI yet though. Maybe it can go in a seperate PR or if there are references I could use for this I can get started right away.

Ticket Link

#29

@maisnamraju maisnamraju requested a review from larkox as a code owner August 12, 2021 11:21
@mattermod
Copy link
Contributor

Hello @maisnamraju,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei hanzei added the Invalid This doesn't seem right label Aug 12, 2021
@hanzei hanzei removed the request for review from larkox August 12, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning when creating a meeting on channels
4 participants