Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command autocomplete feature #101

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add command autocomplete feature #101

merged 2 commits into from
Jul 11, 2024

Conversation

ayusht2810
Copy link
Contributor

@ayusht2810 ayusht2810 commented Apr 19, 2024 •
edited
Loading

Summary

  • Added command autocomplete feature

Ticket Link

Fixes #53

Note: CI will be fixed after merging of PR #100

@ayusht2810 ayusht2810 requested a review from larkox as a code owner April 19, 2024 11:41
@ayusht2810 ayusht2810 self-assigned this Apr 19, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 19, 2024
mickmister
mickmister approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up that there are some linting errors related to unused function parameters

@ayusht2810
Copy link
Contributor Author

Heads up that there are some linting errors related to unused function parameters

@mickmister I have fixed CI in the PR #100

@ayusht2810
Copy link
Contributor Author

@mickmister Should I move the PR for QA review?

@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Apr 25, 2024
AayushChaudhary0001
AayushChaudhary0001 approved these changes Jun 27, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above PR has been tested for the following scenario:

  • Checked the newly added command autocomplete feature

The PR was working fine for the mentioned condition. LGTM. Approved

@raghavaggarwal2308 raghavaggarwal2308 merged commit 77898b0 into master Jul 11, 2024
4 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the fix-issue-53 branch July 11, 2024 10:29
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.2.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@mickmister mickmister mickmister approved these changes

@larkox larkox larkox approved these changes

Assignees

@ayusht2810 ayusht2810

Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Add command autocomplete
5 participants
@ayusht2810 @larkox @mickmister @raghavaggarwal2308 @AayushChaudhary0001