Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when creating a meeting on channels #29

Open
larkox opened this issue Nov 13, 2020 · 5 comments
Open

Add warning when creating a meeting on channels #29

larkox opened this issue Nov 13, 2020 · 5 comments
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@larkox
Copy link
Contributor

larkox commented Nov 13, 2020

Channels (public and private) may have lots of people in the channel, and creating a meeting on those is oftentimes a mistake or a missclick. We would like to add a confirmation message when creating a meeting on public and private channels, warning the user they are about to create a meeting in a channel with X users, with a button to create the meeting either way.

@larkox larkox added Type/Enhancement New feature or improvement of existing feature Help Wanted Community help wanted Difficulty/1:Easy Easy ticket Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Nov 13, 2020
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jul 13, 2021
@maisnamrajusingh
Copy link
Contributor

@larkox will something like this do ?
Screenshot 2021-08-03 at 6 24 52 PM

@larkox
Copy link
Contributor Author

larkox commented Aug 3, 2021

@aaronrothschild would be the right person to ask about the final aesthetics, but the idea would be that, yes.

Also, I guess that is meant to be a Custom Post type. It would be nice to have also a "Interactive Message" version so mobile clients can also interact. If I am not mistaken the "start meeting" message behaves in the same way (i.e. having the two versions).

@aaronrothschild
Copy link
Contributor

Thanks @larkox , agreed with interactive Message for mobile clients.

Please remove the "Confirm you want to start the meeting" part of the message.

Change the button to read "Create Meeting"

@maisnamrajusingh
Copy link
Contributor

maisnamrajusingh commented Aug 12, 2021

@aaronrothschild are there any references I could use for the Mobile clients ? I'll send out an interim PR for now with the above mentioned changes.

@aaronrothschild
Copy link
Contributor

@aaronrothschild are there any references I could use for the Mobile clients ? I'll send out an interim PR for now with the above mentioned changes.

I think this should give you an idea - https://docs.mattermost.com/developer/interactive-messages.html

@larkox may have some samples of code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
5 participants