Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-01: Hardcoded Modular Length Value in Return Statement #1370

Open
wants to merge 1 commit into
base: draft-v28
Choose a base branch
from

Conversation

Raid5594
Copy link
Collaborator

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@Raid5594 Raid5594 changed the base branch from main to draft-v28 March 26, 2025 11:17
Copy link

Coverage after merging ra/precompile-fix-l-01 into main will be

87.05%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   L1ERC20Bridge.sol87.50%100%87.50%87.50%69–71, 73–74
   L1SharedBridge.sol83.61%100%84.21%83.52%102, 110, 118, 124–126, 191, 200, 213, 216, 226–232, 234, 239–242, 244–247, 249, 255, 261, 269–271, 445, 448, 580, 597, 608, 624, 721, 961–962, 966–967
contracts/bridgehub
   Bridgehub.sol93.85%100%100%92.86%101, 113, 133, 156, 159, 333, 49, 64
contracts/common
   ReentrancyGuard.sol95%100%100%94.12%79
contracts/common/libraries
   L2ContractHelper.sol51.85%100%50%52.17%26, 32, 36, 49–50, 52–53, 57–58, 65–66
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   ChainAdmin.sol0%100%0%0%26–28, 30, 32–33, 38–40, 46–48, 55–57, 60, 62–63, 66, 69, 77–79, 81
   Governance.sol99.08%100%100%98.88%45
contracts/state-transition
   StateTransitionManager.sol59.65%100%50%61.87%101, 105–110, 115–116, 150, 153, 156, 159, 199, 201, 203–204, 208–209, 211–212, 215–217, 219–220, 254–255, 274–275, 284, 289, 293–294, 298–299, 303–304, 308–309, 313–314, 318–319, 385–387, 390, 456, 91–93, 99
   TestnetVerifier.sol87.50%100%100%83.33%32
   ValidatorTimelock.sol97.67%100%100%97.01%241, 83
   Verifier.sol91.41%100%96.30%91.19%1674, 284, 287–302, 305–308, 311–318, 321–328, 331–332, 335–336, 339, 385, 396, 407, 418, 429, 445, 454–455, 905
contracts/state-transition/chain-deps
   DiamondInit.sol86.84%100%100%86.49%35, 38, 41, 44, 47
   DiamondProxy.sol100%100%100%100%
contracts/state-transition/chain-deps/facets
   Admin.sol88.76%100%92.31%88.16%107, 109–110, 112–113, 178, 180, 84, 95
   Executor.sol87.18%100%84.38%87.50%138, 231, 236, 242, 245, 261, 275, 280, 295, 362, 421, 425, 448–449, 463, 469, 48–49, 520, 529, 548–549, 557, 59–60, 62, 620, 63, 647, 697, 701, 71, 75, 773, 775
   Getters.sol91.43%100%90.24%91.92%151, 153, 205–206, 71–72, 76–77
   Mailbox.sol100%100%100%100%
   ZkSyncHyperchainBase.sol96.43%100%100%95.24%56
contracts/state-transition/libraries
   Diamond.sol96.64%100%100%96.33%110, 120, 199, 316
   LibMap.sol100%100%100%100%
   Merkle.sol100%100%100%100%
   PriorityQueue.sol100%100%100%100%
   TransactionValidator.sol96.67%100%100%96.36%67, 70
contracts/upgrades
   BaseZkSyncUpgrade.sol68.75%100%100%65%104–105, 108, 111, 114–115, 126–127, 130, 133, 136–137, 151–153, 171–173, 213, 215–216, 233, 250, 253, 258–260, 272, 279, 286, 294, 299, 309, 312, 76
   BaseZkSyncUpgradeGenesis.sol70.83%100%100%69.57%25–26, 34, 41, 53, 63, 66
   DefaultUpgrade.sol100%100%100%100%
   GenesisUpgrade.sol100%100%100%100%
contracts/vendor
   AddressAliasHelper.sol100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant