feat: create e2e tests for common actions #224
Conversation
|
Visit the preview URL for this PR (updated for commit 2f47346): https://staging-zksync-dapp-wallet-v2--pr224-tx-nikola-txfusio-8wzkh9il.web.app (expires Thu, 05 Jun 2025 11:45:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a25831e6058958ccabf0f806505b5b8e7241b178 |
.github/workflows/e2e.yml
Outdated
| network: | ||
| type: string | ||
| default: 'Sepolia' | ||
| default: "Goerli" |
components/token/TokenLine.vue
Outdated
| price: { | ||
| type: [String, Number] as PropType<TokenPrice>, | ||
| }, | ||
| dataTestid: { |
There was a problem hiding this comment.
You don't have to add this prop everywhere if it will be mounted directly to the main element. It will already be inherited by default.
| Given I go to "Deposit" transaction section | ||
| When I click by "text" with "Your account" value | ||
| Then Element with "id" "amount-input" should have "" "value" | ||
| Given I go to page "/bridge?network=sepolia" |
There was a problem hiding this comment.
Don't we setup env somewhere else in the configs? Why do we need to hardcode ?network=...
| # Encrypted rich wallet mnemonic: | ||
| E2E_WALLET_1_MAIN_PUB_KEY= | ||
| E2E_WALLET_2_SECOND_PUB_KEY= | ||
| E2E_WALLET_0_EMPTY_PUB_KEY= | ||
|
|
||
| # Public addresses | ||
| E2E_WALLET_1_MAIN= | ||
| E2E_WALLET_2_SECOND= | ||
| E2E_WALLET_0_EMPTY= | ||
| E2E_WALLET_PASSWORD_MM= | ||
|
|
||
| # Our random key for encryption | ||
| E2E_WALLET_SECRET_PK= | ||
| # Our random salt for encryption | ||
| E2E_WALLET_SALT_IV= No newline at end of file |
There was a problem hiding this comment.
The setup looks quite complicated. Do we really need all that? Do we need to keep track of so many secrets that I used for encryption, etc?
There was a problem hiding this comment.
I can update this - what would you prefer?
We can use the plain-text values in the env file so we don't need to handle the encryption, or do you have something else in mind?
|
Updated to remove the unnecessary env variables - now we just need the mnemonic seed phrase for 2 wallets. |
2 participants
Refactor the E2E tests so that they can be run in the new redesigned structure.
@transactionstag.They test the functionalities of:
This PR fixes #213