update

[gouhongshen]

PR Type

Bug fix

---

Description

• Fix connection ID regex pattern validation

• Increase default connection pool size to 1000

---

Changes diagram

flowchart LR
  A["Connection ID Validation"] --> B["Fix regex pattern [0-9]+"]
  C["Connection Pool"] --> D["Increase size to 1000"]

Loading

---

Changes walkthrough 📝

	Relevant files
Configuration changes	COMMON.java Increase default connection pool size                                        src/main/java/io/mo/constant/COMMON.java Increase DEFAULT_CONNECTION_NUM from 10 to 1000 +1/-1
Bug fix	ScriptParser.java Fix connection ID regex validation                                              src/main/java/io/mo/util/ScriptParser.java Fix regex pattern from [0-9] to [0-9]+ for connection ID validation Allow multi-digit connection IDs instead of single digits only +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Performance Impact The connection pool size increased from 10 to 1000 (100x increase) which could significantly impact memory usage and resource consumption. This dramatic change should be validated against system capacity and actual usage patterns. public static int DEFAULT_CONNECTION_NUM = 1000; Logic Gap The regex fix allows multi-digit connection IDs but there's no validation against the maximum allowed connection ID or bounds checking before parsing to integer, which could lead to runtime issues. if(id.matches("[0-9]+")){ con_id = Integer.parseInt(id);

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add bounds checking for parsing The regex pattern allows unlimited digits which could cause integer overflow when parsing very large numbers. Add bounds checking to prevent NumberFormatException or invalid connection IDs. src/main/java/io/mo/util/ScriptParser.java [187-189] -if(id.matches("[0-9]+")){ +if(id.matches("[0-9]+") && id.length() <= 9){ con_id = Integer.parseInt(id); } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a potential NumberFormatException from integer overflow, which is a valid bug introduced by allowing multi-digit IDs, and proposes a reasonable solution.	Medium
	Reduce excessive connection pool size The increase from 10 to 1000 connections is a 100x jump that could overwhelm system resources. Consider a more gradual increase or make this configurable to avoid potential memory issues and connection pool exhaustion. src/main/java/io/mo/constant/COMMON.java [17] -public static int DEFAULT_CONNECTION_NUM = 1000; +public static int DEFAULT_CONNECTION_NUM = 50; // or make it configurable Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly points out that increasing DEFAULT_CONNECTION_NUM by 100x is a significant change that could cause performance or resource issues, which is a valid concern.	Medium
Update