Skip to content

[MatrixRTC] Improve is livekit checks to check for field availability and first. #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[MatrixRTC] Improve is livekit checks to check for field availability and first. #5039

wants to merge 2 commits into from
+21 −2

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Oct 10, 2025 •
edited
Loading

Otherwise passing undefined throws.

Signed-off-by: Timo K [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5
Improve is livekit checks to check for field
14cc1bb 
availability and first.

Signed-off-by: Timo K <[email protected]>
@toger5
add test
3e24e15 
Signed-off-by: Timo K <[email protected]>
@toger5 toger5 marked this pull request as ready for review October 10, 2025 09:01
@toger5 toger5 requested a review from a team as a code owner October 10, 2025 09:01
@toger5 toger5 requested a review from AndrewFerr October 10, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from matrix-org/element-call-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

T-Defect

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@toger5