Add configurable timeoutMs option to uploadContent #5032
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
florianduros
requested changes
Oct 7, 2025
Comment on lines
+210
to
+214
| /** | ||
| * Optional. Timeout in milliseconds before the upload is aborted. | ||
| * Defaults to 30000 (30 seconds) if not specified. | ||
| */ | ||
| timeoutMs?: number; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Optional. Timeout in milliseconds before the upload is aborted. | |
| * Defaults to 30000 (30 seconds) if not specified. | |
| */ | |
| timeoutMs?: number; | |
| /** | |
| * Timeout in milliseconds before the upload is aborted. | |
| * @default 30000 (30 seconds) | |
| */ | |
| timeoutMs?: number; |
|
|
||
| // set an initial timeout of 30s; we'll advance it each time we get a progress notification | ||
| let timeoutTimer = callbacks.setTimeout(timeoutFn, 30000); | ||
| // set an initial timeout (default to 30s); extendable via opts.timeoutMs |
There was a problem hiding this comment.
Suggested change
| // set an initial timeout (default to 30s); extendable via opts.timeoutMs | |
| // set an initial timeout (default to 30s); extendable via opts.timeoutMs | |
| // we'll advance it each time we get a progress notification |
|
You've checked the box to say you've signed off your changes and written tests, but I don't see either of these things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.