Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export membership types #4405

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Export membership types #4405

merged 2 commits into from
Sep 14, 2024

Conversation

Johennes
Copy link
Contributor

This came up in #4394 (comment).

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 13, 2024
@Johennes Johennes mentioned this pull request Sep 13, 2024
Merged
4 tasks
@Johennes Johennes marked this pull request as ready for review September 13, 2024 14:50
@Johennes Johennes requested a review from a team as a code owner September 13, 2024 14:50
@richvdh richvdh added T-Feature Request to add a new feature which does not exist right now T-Enhancement and removed T-Feature Request to add a new feature which does not exist right now labels Sep 13, 2024
@richvdh richvdh added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@richvdh
Copy link
Member

richvdh commented Sep 13, 2024 •
edited
Loading

CI failed due to element-hq/element-web#28048

@richvdh richvdh added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@Johennes
Copy link
Contributor Author

Sorry for the hassle. I probably should've just tagged this onto the other PR but I hadn't expected you to land it so quickly.

@richvdh richvdh added this pull request to the merge queue Sep 14, 2024
@richvdh
Copy link
Member

richvdh commented Sep 14, 2024

It's no hassle! Sorry about our flaky CI 😞

Merged via the queue into matrix-org:develop with commit 53b599f Sep 14, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johennes @richvdh