Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & improve MultiSites plugin #23065

Merged
merged 10 commits into from
Feb 26, 2025
Merged

Refactor & improve MultiSites plugin #23065

merged 10 commits into from
Feb 26, 2025

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 24, 2025

Description:

Review

@sgiehl sgiehl added the Technical debt Issues the will help to reduce technical debt label Feb 24, 2025
@sgiehl sgiehl added this to the 5.3.0 milestone Feb 24, 2025
@sgiehl sgiehl force-pushed the dev-18952 branch 8 times, most recently from a4e1524 to 725df64 Compare February 24, 2025 17:13
Base automatically changed from DEV-18951 to 5.x-dev February 25, 2025 08:52
@sgiehl sgiehl force-pushed the dev-18952 branch 2 times, most recently from 5c1dca3 to 3f04200 Compare February 25, 2025 12:02
@sgiehl sgiehl changed the title Refactor & improve MultiSites plugins Refactor & improve MultiSites plugin Feb 25, 2025
@sgiehl sgiehl requested a review from a team February 25, 2025 19:21
@sgiehl sgiehl marked this pull request as ready for review February 25, 2025 19:21
@caddoo caddoo self-assigned this Feb 25, 2025
Copy link
Contributor

@caddoo caddoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up 🧹

A bit cleaner now, still lot's of responsibilities within the API class, but 100% an improvement.

@caddoo caddoo removed their assignment Feb 26, 2025
@caddoo caddoo merged commit 1505379 into 5.x-dev Feb 26, 2025
26 checks passed
@caddoo caddoo deleted the dev-18952 branch February 26, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical debt Issues the will help to reduce technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants