Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more options for global URL parameter exclusions #22729

Open
wants to merge 63 commits into
base: 5.x-dev
Choose a base branch
from
Open

Add more options for global URL parameter exclusions #22729

wants to merge 63 commits into from
+996 −135

Commits on Nov 4, 2024

  1. Update global settings to support excluding common PII params

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3abdabe View commit details
    Browse the repository at this point in the history

  2. Clean up TS

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6ff6084 View commit details
    Browse the repository at this point in the history

  3. Add UI screenshots (with some commented)

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    baf1d9d View commit details
    Browse the repository at this point in the history

  4. Remove empty test

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d0fb658 View commit details
    Browse the repository at this point in the history

  5. Fix broken UI test

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0f30e6d View commit details
    Browse the repository at this point in the history

  6. Fix broken UI test

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8efbeef View commit details
    Browse the repository at this point in the history

  7. Fix broken integration test

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8269536 View commit details
    Browse the repository at this point in the history

  8. Merge branch '5.x-dev' into dev-18646-add-button-add-list-of-exclusio… 

    …ns-globally
    @caddoo
    caddoo authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4d9cd4d View commit details
    Browse the repository at this point in the history

  9. Build vue files

    @innocraft-automation
    innocraft-automation committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    75db8c4 View commit details
    Browse the repository at this point in the history

  10. Update UI to hide the list of common exclusions

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    639ddcc View commit details
    Browse the repository at this point in the history

  11. Build vue files

    @innocraft-automation
    innocraft-automation committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cd39b1a View commit details
    Browse the repository at this point in the history

  12. Update UI screenshot

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    84dfef1 View commit details
    Browse the repository at this point in the history

  13. Update UI screenshot

    @caddoo
    caddoo committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    297f59e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Update API interface to keep data integrity

    @caddoo
    caddoo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7a5b07a View commit details
    Browse the repository at this point in the history

  2. Switch to using whitelist validator

    @caddoo
    caddoo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8949a69 View commit details
    Browse the repository at this point in the history

  3. Update exceptions to be translated, add missing integration test

    @caddoo
    caddoo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a53ba24 View commit details
    Browse the repository at this point in the history

  4. Restore commented out UI tests

    @caddoo
    caddoo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    21b31db View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove redundant switch statement

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e414625 View commit details
    Browse the repository at this point in the history

  2. Add return type

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    73c8350 View commit details
    Browse the repository at this point in the history

  3. Move common PII exclusions to config

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a6fec12 View commit details
    Browse the repository at this point in the history

  4. Translate button text

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c8d080d View commit details
    Browse the repository at this point in the history

  5. Add common PII to config

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    36161ad View commit details
    Browse the repository at this point in the history

  6. Deprecate setGlobalExcludedQueryParameters

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    da7bd72 View commit details
    Browse the repository at this point in the history

  7. Fix CS issues

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b623614 View commit details
    Browse the repository at this point in the history

  8. Build vue files

    @innocraft-automation
    innocraft-automation committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9288ac5 View commit details
    Browse the repository at this point in the history

  9. Fix deprecated test and update changelog

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4869ad7 View commit details
    Browse the repository at this point in the history

  10. Use test config data for test, remove static copy of common PII

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6b93491 View commit details
    Browse the repository at this point in the history

  11. Add missing translation key

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c5d3fad View commit details
    Browse the repository at this point in the history

  12. Update UI screenshots

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9ea605a View commit details
    Browse the repository at this point in the history

  13. Fix tests

    @caddoo
    caddoo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b541e1a View commit details
    Browse the repository at this point in the history

  14. Merge branch '5.x-dev' into dev-18646-add-button-add-list-of-exclusio… 

    …ns-globally
    @caddoo
    caddoo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4c305c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Update plugins/SitesManager/API.php 

    Co-authored-by: Marc Neudert <[email protected]>
    @caddoo @mneudert
    caddoo and mneudert authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    3af38c1 View commit details
    Browse the repository at this point in the history

  2. Update plugins/SitesManager/API.php 

    Co-authored-by: Marc Neudert <[email protected]>
    @caddoo @mneudert
    caddoo and mneudert authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    1476f50 View commit details
    Browse the repository at this point in the history

  3. Update plugins/SitesManager/API.php 

    Co-authored-by: Marc Neudert <[email protected]>
    @caddoo @mneudert
    caddoo and mneudert authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d9236c8 View commit details
    Browse the repository at this point in the history

  4. Update plugins/SitesManager/vue/src/ManageGlobalSettings/ManageGlobal… 

    …Settings.vue

Co-authored-by: Marc Neudert <[email protected]>
    @caddoo @mneudert
    caddoo and mneudert authored Nov 10, 2024
    Configuration menu
    Copy the full SHA
    69169d2 View commit details
    Browse the repository at this point in the history

  5. Reorder and remove duplicates for CommonPII params

    @caddoo
    caddoo committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    31864a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Clear query parameters when custom_exclusions selected

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b80ece9 View commit details
    Browse the repository at this point in the history

  2. Add missing prop type include

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2334c8d View commit details
    Browse the repository at this point in the history

  3. Make old API method more compatible with new methods

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0998402 View commit details
    Browse the repository at this point in the history

  4. Merge branch '5.x-dev' into dev-18646-add-button-add-list-of-exclusio… 

    …ns-globally
    @caddoo
    caddoo authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8200473 View commit details
    Browse the repository at this point in the history

  5. Fix syntax error

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4f8e909 View commit details
    Browse the repository at this point in the history

  6. Fix UI screenshot

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b4a9eb9 View commit details
    Browse the repository at this point in the history

  7. Build vue files

    @innocraft-automation
    innocraft-automation committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    caa50ca View commit details
    Browse the repository at this point in the history

  8. Fix UI screenshot

    @caddoo
    caddoo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    643fa6f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update plugins/SitesManager/API.php 

    Co-authored-by: Marc Neudert <[email protected]>
    @caddoo @mneudert
    caddoo and mneudert authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bfca00e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Make sure URL params are cleaned before validation, and add tests

    @caddoo
    caddoo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dc7251b View commit details
    Browse the repository at this point in the history

  2. Remove redundant check

    @caddoo
    caddoo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    54ef856 View commit details
    Browse the repository at this point in the history

  3. Update naming for the exclusion types

    @caddoo
    caddoo committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a26b1c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Build vue files

    @innocraft-automation
    innocraft-automation committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    69dc3fa View commit details
    Browse the repository at this point in the history

  2. Update wording once more

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a121d18 View commit details
    Browse the repository at this point in the history

  3. Update ui screenshots

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f973c0c View commit details
    Browse the repository at this point in the history

  4. Update ui screenshots

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4ab0b83 View commit details
    Browse the repository at this point in the history

  5. Update ui screenshots

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    14302c9 View commit details
    Browse the repository at this point in the history

  6. Update ui screenshots

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f9aed0e View commit details
    Browse the repository at this point in the history

  7. Update expected integration test

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3afa175 View commit details
    Browse the repository at this point in the history

  8. Update language again

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0787133 View commit details
    Browse the repository at this point in the history

  9. Update integration test expected result

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4714d7e View commit details
    Browse the repository at this point in the history

  10. Temp split test to get all screenshots

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ca8ab48 View commit details
    Browse the repository at this point in the history

  11. Fix broken tests

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f278b42 View commit details
    Browse the repository at this point in the history

  12. Merge branch '5.x-dev' into dev-18646-add-button-add-list-of-exclusio… 

    …ns-globally
    @caddoo
    caddoo authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cf3f647 View commit details
    Browse the repository at this point in the history

  13. Remove temp tests

    @caddoo
    caddoo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f141197 View commit details
    Browse the repository at this point in the history

  14. Split UI tests to "one screenshot per test" for ease of updating

    @mneudert
    mneudert committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9463b5c View commit details
    Browse the repository at this point in the history

  15. Remove duplicated translation

    @mneudert
    mneudert committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    af112f5 View commit details
    Browse the repository at this point in the history