Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D printing files to download extensions #22728

Open
wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from

Conversation

nallath
Copy link

@nallath nallath commented Oct 30, 2024

Description:

Add STL, OBJ, 3MF and PLY to download extensions.

It also re-orders the list to make sure that they are completely alphabetical. Not entirely sure if this is a requirement, but it was almost following it, making it a bit confusing.

Review

Add STL, OBJ, 3MF and PLY to download extensions.

It also re-orders the list to make sure that they are completely alphabetical. Not entirely sure if this is a requirement, but it was almost following it, making it a bit confusing.
@michalkleiner
Copy link
Contributor

Hi @nallath! Thanks for creating the PR. We have some failing tests now as when the list is adjusted, the tracker files need to be regenerated. Are you able to do that as well, please? If not, that's ok, just let us know, and one of the team members can look at it at some point.

@nallath
Copy link
Author

nallath commented Nov 4, 2024

@michalkleiner I don't actually have a full dev env setup. I did try to run the scripts to minify it, but they need it.

So yeah, I would prefer it if someone could help out with that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants