Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload access after new session is created #22725

Open
wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from

Conversation

michalkleiner
Copy link
Contributor

Description:

It may happen that when accessing user settings right after user login the value may not be yet loaded and the default value is returned instead, even though a session is already created.

This forced access reload seems to fix that particular issue.

Review

@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Needs Review PRs that need a code review labels Oct 30, 2024
@michalkleiner michalkleiner added this to the 5.2.0 milestone Oct 30, 2024
@michalkleiner michalkleiner requested a review from a team October 30, 2024 04:54
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 7, 2024
@michalkleiner michalkleiner added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant