Show install all plugins button on Manage Plugins and License key section #22615
Conversation
…ense key section, #PG-3698
| @@ -227,6 +229,32 @@ public function removePluginTrialRequest(string $pluginName): void | |||
| } | |||
| } | |||
|
|
|||
| public function isInstallAllPaidPluginsVisible(): bool | |||
| { | |||
| $consumer = StaticContainer::get('Piwik\Plugins\Marketplace\Consumer'); | |||
There was a problem hiding this comment.
To test add below code
| $consumer = StaticContainer::get('Piwik\Plugins\Marketplace\Consumer'); | |
| return true; | |
| $consumer = StaticContainer::get('Piwik\Plugins\Marketplace\Consumer'); |
|
|
||
| public function getPaidPluginsToInstallAtOnce(): array | ||
| { | ||
| $plugins = StaticContainer::get('Piwik\Plugins\Marketplace\Plugins'); |
There was a problem hiding this comment.
To test also add this here
| $plugins = StaticContainer::get('Piwik\Plugins\Marketplace\Plugins'); | |
| return ['ActivityLog']; | |
| $plugins = StaticContainer::get('Piwik\Plugins\Marketplace\Plugins'); |
sgiehl
changed the title
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
AltamashShaikh
requested review from
sgiehl and
michalkleiner
and removed request for
sgiehl
|
@matomo-org/core-reviewers Can anyone check this ? |
| @@ -38,15 +44,23 @@ import { | |||
| translate, | |||
| MatomoUrl, | |||
| } from 'CoreHome'; | |||
| import InstallAllPaidPluginsButton from '../../../../Marketplace/vue/src/InstallAllPaidPluginsButton/InstallAllPaidPluginsButton.vue'; | |||
There was a problem hiding this comment.
We should only reference that relative, if it is within the same plugin. Here simply importing it from Marketplace should also work.
| $view->isInstallAllPaidPluginsVisible = $marketplace->isInstallAllPaidPluginsVisible(); | ||
| $view->paidPluginsToInstallAtOnce = $marketplace->getPaidPluginsToInstallAtOnce(); | ||
| $view->installAllPluginsNonce = Nonce::getNonce(\Piwik\Plugins\Marketplace\Controller::INSTALL_NONCE); |
There was a problem hiding this comment.
I'm wondering if it might be smarter to change the InstallButton component to fetch all required information through a ajax request to a controller action (NOT api, due to the required token) instead of passing that through all controllers, views and vue components. Would be an additional request, but imho a lot simpler to reuse everywhere.
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
Description:
Add code to show install all plugins button on Manage Plugins and License key section
Fixes: #PG-3698
Review