Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of action custom dimension metrics #22571

Draft
wants to merge 7 commits into
base: 5.x-dev
Choose a base branch
from
Draft

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 10, 2024

Description:

The calculation of some metrics for action custom dimensions was not correct.

We used to fetch all metrics grouped by custom dimension value and url to be able to directly fill the subtable reports.
The main report was then created by aggregating the subtable values.

This results in incorrect numbers, as e.g. metrics like nb_visits or nb_uniq_visitors can't be simply summed up. They need to be fetched separately from the database.

This PR changes the archiving, so it uses two queries. One to fetch the metrics for the main report (grouped by custom dimension value only) and another query to fetch the data for subtable reports (grouped by custom dimension value and url).

fixes #19164

Review

Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 26, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Dimension with action scope: number of visits missing or is wrong
1 participant