Fix calculation of action custom dimension metrics #22571
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The calculation of some metrics for action custom dimensions was not correct.
We used to fetch all metrics grouped by custom dimension value and url to be able to directly fill the subtable reports.
The main report was then created by aggregating the subtable values.
This results in incorrect numbers, as e.g. metrics like
nb_visits
ornb_uniq_visitors
can't be simply summed up. They need to be fetched separately from the database.This PR changes the archiving, so it uses two queries. One to fetch the metrics for the main report (grouped by custom dimension value only) and another query to fetch the data for subtable reports (grouped by custom dimension value and url).
fixes #19164
Review